Fix/termination #113
Closed
Fix/termination #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@0xArdi maybe instead of merging this we should do it on core packages. WDYT? |
0xArdi
approved these changes
Nov 30, 2023
dvilelaf
commented
Nov 30, 2023
Comment on lines
+195
to
+196
| from_block=self.params.termination_from_block, | ||
| chain_id=self.params.termination_chain |
There was a problem hiding this comment.
@Adamantios these 2 lines have changed. I added the custom block and chain_id
dvilelaf
commented
Nov 30, 2023
Comment on lines
+228
to
+229
| from_block=self.params.termination_from_block, | ||
| chain_id=self.params.termination_chain |
There was a problem hiding this comment.
@Adamantios same thing
Adamantios
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fixes
n/a
Types of changes
What types of changes does your code introduce? (A breaking change is a fix or feature that would cause existing functionality and APIs to not work as expected.)
Put an
xin the box that appliesChecklist
Put an
xin the boxes that apply.mainbranch (left side). Also you should start your branch off ourmain.Further comments
n/a